Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix outdated comment regarding multiple faker locales #2433

Merged
merged 6 commits into from
Oct 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 5, 2023

Fixes #2392

I searched for other related outdated sections, but couldn't find any.

I removed the section because faker now only contains a single locale per faker instance.

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Oct 5, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 5, 2023
@ST-DDT ST-DDT requested review from a team October 5, 2023 18:40
@ST-DDT ST-DDT self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2433 (9c7bac4) into next (57bcd97) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2433      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255523   255523              
  Branches     1105     1104       -1     
==========================================
- Hits       254487   254483       -4     
- Misses       1008     1012       +4     
  Partials       28       28              

see 2 files with indirect coverage changes

@ST-DDT ST-DDT merged commit c80c035 into next Oct 7, 2023
20 checks passed
@ST-DDT ST-DDT deleted the docs/readme-cleanup branch October 7, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The README section 'Usage' mentions example code that does not exist.
3 participants