Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: randomizer cleanup #2431

Merged
merged 6 commits into from
Oct 6, 2023
Merged

chore: randomizer cleanup #2431

merged 6 commits into from
Oct 6, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 5, 2023

Cleanup PR for some missed changes.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Oct 5, 2023
@ST-DDT ST-DDT added this to the v8.x milestone Oct 5, 2023
@ST-DDT ST-DDT requested review from a team October 5, 2023 00:36
@ST-DDT ST-DDT self-assigned this Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2431 (6c9a419) into next (491d319) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2431   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2823     2823           
  Lines      255522   255523    +1     
  Branches     1103     1106    +3     
=======================================
+ Hits       254478   254480    +2     
+ Misses       1016     1015    -1     
  Partials       28       28           
Files Coverage Δ
src/internal/mersenne.ts 96.30% <100.00%> (+0.01%) ⬆️
src/simple-faker.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

import-brain
import-brain previously approved these changes Oct 5, 2023
src/internal/mersenne.ts Outdated Show resolved Hide resolved
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
@ST-DDT ST-DDT requested review from import-brain and a team October 5, 2023 08:40
import-brain
import-brain previously approved these changes Oct 5, 2023
matthewmayer
matthewmayer previously approved these changes Oct 5, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be nitpicky.

test/mersenne.spec.ts Show resolved Hide resolved
src/internal/mersenne.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT dismissed stale reviews from matthewmayer and import-brain via 9670704 October 5, 2023 16:36
@ST-DDT ST-DDT merged commit c0386ac into next Oct 6, 2023
20 checks passed
@ST-DDT ST-DDT deleted the chore/randomizer-cleanup branch October 6, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants