Fix #601 - Detect Chrome OS without version

faisalman · Jan 31, 2023 · f8e5a1f · f8e5a1f
1 parent c9d1ab9
commit f8e5a1f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/ua-parser.js b/src/ua-parser.js
@@ -738,7 +738,7 @@
             // Google Chromecast
             /crkey\/([\d\.]+)/i                                                 // Google Chromecast
             ], [VERSION, [NAME, CHROME+'cast']], [
-            /(cros) [\w]+ ([\w\.]+\w)/i                                         // Chromium OS
+            /(cros) [\w]+(?:\)| ([\w\.]+)\b)/i                                  // Chromium OS
             ], [[NAME, 'Chromium OS'], VERSION],[
 
             // Smart TVs

diff --git a/test/os-test.json b/test/os-test.json
@@ -665,6 +665,15 @@
             "version" : "1.9.2.22-0.1mdv2010.2"
         }
     },
+    {
+        "desc"    : "Chrome OS",
+        "ua"      : "Mozilla/5.0 (X11; CrOS x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.0.0 Safari/537.36",
+        "expect"  :
+        {
+            "name"    : "Chromium OS",
+            "version" : "undefined"
+        }
+    },
     {
         "desc"    : "Chromium OS",
         "ua"      : "Mozilla/5.0 (X11; CrOS x86_64 10575.58.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36",