Skip to content

Commit

Permalink
Bump SKID_MARGIN_RCBS from 60 to 70
Browse files Browse the repository at this point in the history
Summary:
For AMD hosts I'm seeing issues with trying to run `mkfs.ext3` at large sizes using Antlir. We can raise it slightly to deal with this issue.

If it becomes too much of a problem for Intel hosts, we can always break out compilation for the two processor types

Reviewed By: jasonwhite

Differential Revision: D56271985

fbshipit-source-id: 1af3a007363a241cfa1c3e12585d6f837b274d19
  • Loading branch information
CookieComputing authored and facebook-github-bot committed Apr 18, 2024
1 parent 9a1320b commit d296065
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions reverie-ptrace/src/timer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,8 @@ impl EventStatus {
/// `rr` uses a value of 100 for almost all platforms, but with precise_ip = 0.
/// Enabling Intel PEBS via precise_ip > 0 seems to reduce observed skid by 1/2,
/// in synthetic benchmarks, though it makes counter _values_ incorrect. As a
/// result, we choose 60.
const SKID_MARGIN_RCBS: u64 = 60;
/// result, we choose 70.
const SKID_MARGIN_RCBS: u64 = 70;

/// We refuse to schedule a "perf timeout" for this or fewer RCBs, instead
/// choosing to directly single step. This is because I am somewhat paranoid
Expand Down

0 comments on commit d296065

Please sign in to comment.