[hermit][open-source] Add an extremely basic test script #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: While we wait to port our full buck testing setup to the OSS build, it's best to get at least a few integration tests running. This diff uses a bash script for the purpose, though the next step would be to replace it with Rust code, possibly using libtest directly. Test Plan: Reviewers: Subscribers: Tasks: Tags:
facebook-github-bot
added
the
CLA Signed
|
Looks like perf counters are not enabled on the hosted Github Actions Runners. There is a way we can host our own or can try checking out Circle Ci too |
|
Well, that sounds more involved. In the short term we could just disable RCB counters for these basic "hermit strict" tests. I don't think any require them. |
Summary: The VMs running github actions do not expose perf counters, as seen here: https://github.com/facebookexperimental/hermit/actions/runs/3560943420/jobs/5981398423 WARNING: --preemption-timout requires hardware perf counters which is not supported on this host, resetting preemption-timeout to 0 Therefore, we run only a limited subset of tests under hermit run *without* RCB-based preemption of threads (i.e. busy-wait breaking). Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@rrnewton has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@rrnewton has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While we wait to port our full buck testing setup to the OSS build, it's best to get at least a few integration tests running.
This diff uses a bash script for the purpose, though the next step would be to replace it with Rust code, possibly using libtest directly.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: