[Flight] Expose registerServerReference from the client builds #32534
+141
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
This is used to register Server References that exist in the current environment but also exists in the server it might call into. Such as a remote server. If the value comes from the remote server in the first place then this is called automatically to ensure that you can pass a reference back to where it came from - even if the serverModuleMap option is used .
sebmarkbage
force-pushed
the
fixserverreferences
branch
from
7ece221 to
c91cd03
Compare
gnoff
approved these changes
Mar 6, 2025
unstubbable
added a commit
to unstubbable/react
that referenced
this pull request
Mar 10, 2025
As a follow-up for facebook#32534 this ensures that calling `registerServerReference` from the client builds with a server reference does not overwrite the `bind` method that was previously defined by the Flight Server. As was already the case with facebook#32534, the compiler must ensure that the client-side `registerServerReference` is called after the server-side `registerServerReference` is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to register Server References that exist in the current environment but also exists in the server it might call into. Such as a remote server.
If the value comes from the remote server in the first place then this is called automatically to ensure that you can pass a reference back to where it came from - even if the
serverModuleMapoption is used. This was already the case whenserverModuleMapwasn't passed. This is how you can pass server references back to the server. However, when we addedserverModuleMapthat pass was skipped because we were getting real functions instead of proxies.For functions that wasn't yet passed from the remote server to the current server, we can register them eagerly just like we do for
import('/server').registerServerReference(). You can now also do this withimport('/client').registerServerReference(). We could make them shared so you only have to do this once but it might not be possible to pass to the remote server and the remote server might not even be the same RSC renderer. Therefore I split them. It's up to the compiler whether it should do that or not. It has to know that any function you might call might be able to receive it. This is currently global to a specific RSC renderer.