Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable Hermes to work on iOS #29914

Closed
wants to merge 52 commits into from
Closed

feat: Enable Hermes to work on iOS #29914

wants to merge 52 commits into from

Commits on Sep 9, 2020

  1. feat: initial commit Hermes on iOS

    @grabbou
    grabbou committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    4c21abe View commit details
    Browse the repository at this point in the history

  2. chore: update version

    @grabbou
    grabbou committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1f3598d View commit details
    Browse the repository at this point in the history

  3. Update gradlew.bat

    @grabbou
    grabbou committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    3aa3d95 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. chore: release script tweaks

    @grabbou
    grabbou committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    52bc83a View commit details
    Browse the repository at this point in the history

  2. Remove .gitattributes and normalize line endings (facebook#29792) 

    Summary:
The nested `.gitattributes` file in `packages/react-native-codegen/android/` caused some confusion on Linux and macOS, causing Git to show `packages/react-native-codegen/android/gradlew.bat` as modified (CRLF removed, LF added).

Instead of relying on repo-local `.gitattributes` files to convert endings in the working directory, the files should be committed to source control with the correct line endings in the first place. There is no reason to convert LF endings in .sh and many other file to CRLF on Windows (maybe this was an issue a long time ago, but unless Notepad is used this won't be a problem for practically all modern editors).

Also fixed the line endings of `scripts/launchPackager.bat` which was incorrectly committed as LF.

## Changelog

[Internal] [Fixed] - Line endings and .gitattributes

Pull Request resolved: facebook#29792

Test Plan: Clone repo on Linux, macOS, and Windows, and make sure no modified files show up.

Reviewed By: fkgozali

Differential Revision: D23546135

Pulled By: mdvacca

fbshipit-source-id: 1572fcb959212f212b137066f1aa66f0bb6e86c3
    @friederbluemle @grabbou
    friederbluemle authored and grabbou committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    11112f6 View commit details
    Browse the repository at this point in the history

  3. chore: update line endings after cherry-picking fix

    @grabbou
    grabbou committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    f7592b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat/ios-hermes-try

    @grabbou
    grabbou committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    6921e6b View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. chore: remove hermes-binary.sh file

    @grabbou
    grabbou committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    4b0920b View commit details
    Browse the repository at this point in the history

  2. fix: bundling RNTester in release mode

    @grabbou
    grabbou committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    cb01604 View commit details
    Browse the repository at this point in the history

  3. chore: updating wording

    @grabbou
    grabbou committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    942d009 View commit details
    Browse the repository at this point in the history

  4. chore: do not force bundling, reverting previous changes meant for te… 

    …sting
    @grabbou
    grabbou committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    52c8c2f View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Revert "feat: improve monorepo support by removing redundant PROJECT_… 

    …ROOT (facebook#28354)"

This reverts commit a8e8502.
    @grabbou
    grabbou committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    6afacda View commit details
    Browse the repository at this point in the history

  2. fix: running RNTester and other apps in RELEASE

    @grabbou
    grabbou committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    15a2b9c View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. fix folly errors

    @grabbou
    grabbou committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    16452d0 View commit details
    Browse the repository at this point in the history

  2. chore: remove comment

    @grabbou
    grabbou committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    8c86ae7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. feat: use CocoaPods hermes-engine instead of npm package

    @grabbou
    grabbou committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    e2b2968 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. chore: remove all occurences of hermes-engine-darwin

    @grabbou
    grabbou committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    7310c8a View commit details
    Browse the repository at this point in the history

  2. chore: lock updates

    @grabbou
    grabbou committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    c2adc84 View commit details
    Browse the repository at this point in the history

  3. chore: update comment on a wkroarund

    @grabbou
    grabbou committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    bb6c456 View commit details
    Browse the repository at this point in the history

  4. Revert "Revert "feat: improve monorepo support by removing redundant … 

    …PROJECT_ROOT (facebook#28354)""

This reverts commit 6afacda.
    @grabbou
    grabbou committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a760438 View commit details
    Browse the repository at this point in the history

  5. Fix Xcode bundler in staging and release (facebook#29477) 

    Summary:
Revert "feat: improve monorepo support by removing redundant PROJECT_ROOT (facebook#28354)"

This reverts commit a8e8502.

This commit a8e8502 somehow broke the bundler when making a staging or release build in Xcode that results in unresolved files and main.jsbundle nonexistance issue. I figured this out by replacing react-native-xcode.sh from RN v0.63.2 by the one from v0.62.2 where everything works just fine and then reverting the changes line by line. It seems like this pr will fix similar issues stated here https://stackoverflow.com/questions/62806319/main-jsbundle-does-not-exist-this-must-be-a-bug-with-main-jsbundle-issue-afte/62829256#62829256 and here facebook#29205

## Changelog

[iOS] [Fixed] - fix "main.jsbundle does not exist" issue

Pull Request resolved: facebook#29477

Test Plan:
With react-native-xcode.sh from RN v0.63.2
![image](https://user-images.githubusercontent.com/32848434/88342113-7ce55d80-cd47-11ea-9dab-bf41ec6d6ab5.png)

With my changes
![image](https://user-images.githubusercontent.com/32848434/88342376-f0876a80-cd47-11ea-9c08-96b892784da1.png)

Reviewed By: sammy-SC

Differential Revision: D23817847

Pulled By: hramos

fbshipit-source-id: 4b729c1231d30e89073b2520aeadee944c84421c
    @grabbou
    Makar Kotlov authored and grabbou committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    31c782f View commit details
    Browse the repository at this point in the history

  6. feat: run Hermes from CocoaPods and automatically enable

    @grabbou
    grabbou committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    0f73afb View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. feat: warn about wrong path to Hermes CLI

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    278f33f View commit details
    Browse the repository at this point in the history

  2. chore: remove extra args to Bundle JS and Assets phase

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    62d5619 View commit details
    Browse the repository at this point in the history

  3. chore: revert some changes to xcodeproj

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4fbb834 View commit details
    Browse the repository at this point in the history

  4. chore: temporary fix for running on a simulator in debug mode

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    68f1c31 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/ios-hermes-try

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    3fe22f8 View commit details
    Browse the repository at this point in the history

  6. chore: clean up after merge

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4183b20 View commit details
    Browse the repository at this point in the history

  7. Invalidate cache

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    fe7cbef View commit details
    Browse the repository at this point in the history

  8. chore: do not pull CP repo, its using CDN anyway

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    7fee493 View commit details
    Browse the repository at this point in the history

  9. fix: upgrade CocoaPods to fix Xcode 12 and other issues

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5f92caa View commit details
    Browse the repository at this point in the history

  10. invalidate the cache once again

    @grabbou
    grabbou committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    ec5f23b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. chore: use CocoaPods from Gemfile

    @grabbou
    grabbou committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    82253cf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feat/ios-hermes-try' of github.com:callstack/react-nati… 

    …ve into feat/ios-hermes-try
    @grabbou
    grabbou committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    a1da047 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/ios-hermes-try

    @grabbou
    grabbou committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    9aa5815 View commit details
    Browse the repository at this point in the history

  4. chore: bump xcode to see if it helps

    @grabbou
    grabbou committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    80142fb View commit details
    Browse the repository at this point in the history

  5. chore: bump os

    @grabbou
    grabbou committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    579d03f View commit details
    Browse the repository at this point in the history

  6. fix: some unit tests

    @grabbou
    grabbou committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    e08d0d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. fix: unit tests

    @grabbou
    grabbou committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    5351d68 View commit details
    Browse the repository at this point in the history

  2. fix: build failure of libevent in use_frameworks mode

    @grabbou
    grabbou committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    48eeaa5 View commit details
    Browse the repository at this point in the history

  3. fix: eslint issue

    @grabbou
    grabbou committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    e131e10 View commit details
    Browse the repository at this point in the history

  4. Revert changes to libevent for now

    @grabbou
    grabbou committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    7379157 View commit details
    Browse the repository at this point in the history

  5. Make libevent work for static and framework builds

    @alloy
    alloy committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    e1b79c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Merge pull request #26 from alloy/feat/ios-hermes-try 

    Make libevent work for static and framework builds
    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    170838a View commit details
    Browse the repository at this point in the history

  2. fix: flow issue in test

    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    59a92a2 View commit details
    Browse the repository at this point in the history

  3. chore: point out to Hermes issue

    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    637a5a8 View commit details
    Browse the repository at this point in the history

  4. feat: test jsc/hermes separate

    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    9f924c0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/ios-hermes-try

    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    2dff0ce View commit details
    Browse the repository at this point in the history

  6. chore: remove unused params

    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    d26d900 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feat/ios-hermes-try' of github.com:callstack/react-nati… 

    …ve into feat/ios-hermes-try
    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    ff9d5ec View commit details
    Browse the repository at this point in the history

  8. chore: small docs on enabling Hermes

    @grabbou
    grabbou committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    b400e6c View commit details
    Browse the repository at this point in the history

  9. Update packages/rn-tester/Podfile 

    Co-authored-by: Eloy Durán <eloy.de.enige@gmail.com>
    @grabbou @alloy
    grabbou and alloy committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    9ec3e29 View commit details
    Browse the repository at this point in the history