Support x_google_ignoreList in source map infra #973
Closed
+691
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D43554204 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D43554204 |
motiz88
added a commit
to motiz88/metro
that referenced
this pull request
Apr 25, 2023
Summary: Pull Request resolved: facebook#973 Changelog: * **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate` Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension). An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default. The changes here include: * An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer). * Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles. * Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps. Reviewed By: GijsWeterings Differential Revision: D43554204 fbshipit-source-id: f97255ec5272ad811e049c4db0c2ceca98dab3e2
motiz88
force-pushed
the
export-D43554204
branch
from
27bcbc6 to
f8b691c
Compare
Summary: Pull Request resolved: facebook#973 Changelog: * **[Feature]**: Basic support for `x_google_ignoreList` in `metro-source-map` and `metro-symbolicate` Enables Metro's source map infrastructure to produce and consume the `x_google_ignoreList` field, documented [here](https://developer.chrome.com/blog/devtools-better-angular-debugging/#the-x_google_ignorelist-source-map-extension). An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default. The changes here include: * An option to mark source files as ignored in `metro-source-map`'s `Generator` (used by the serializer). * Preserving ignore lists in `composeSourceMaps`. `composeSourceMaps` is used by React Native in [OSS](https://github.com/facebook/react-native/blob/c1304d938da9cd5016da0bded4d618c42efbd7e4/scripts/compose-source-maps.js#L13) to generate source maps for Hermes bytecode compiled from Metro bundles. * Including an `isIgnored` field in source locations returned via the `metro-symbolicate` API. `metro-symbolicate` is the reference implementation of symbolication based on Metro's source maps. Reviewed By: GijsWeterings Differential Revision: D43554204 fbshipit-source-id: f49f65827ccb1d346eec192c81c53e39597025ab
|
This pull request was exported from Phabricator. Differential Revision: D43554204 |
motiz88
force-pushed
the
export-D43554204
branch
from
f8b691c to
10b7019
Compare
|
This pull request has been merged in d8ca3f2. |
This was referenced May 20, 2024
Open
Open
Open
Open
This was referenced May 28, 2024
Open
Open
Open
Open
Open
This was referenced Jun 5, 2024
Open
Open
This was referenced Aug 14, 2024
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
This was referenced Sep 7, 2024
Open
Open
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
Open
Open
This was referenced Sep 30, 2024
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
x_google_ignoreListinmetro-source-mapandmetro-symbolicateEnables Metro's source map infrastructure to produce and consume the
x_google_ignoreListfield, documented here.An upcoming diff will use this infra support to add ignore lists to Metro's source maps by default.
The changes here include:
metro-source-map'sGenerator(used by the serializer).composeSourceMaps.composeSourceMapsis used by React Native in OSS to generate source maps for Hermes bytecode compiled from Metro bundles.isIgnoredfield in source locations returned via themetro-symbolicateAPI.metro-symbolicateis the reference implementation of symbolication based on Metro's source maps.Differential Revision: D43554204