[lexical-website] Bug Fix: Fix vite.config.ts for gallery examples #7290
+129
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etrepum
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ivailop7
approved these changes
Mar 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since typescript configs are used the conditional import approach (#7208) didn't work for conditional vite plugins, since they still had to exist on disk for rollup to process it. This splits the configuration for all example projects into two files, vite.config.ts and vite.config.monorepo.ts which works around the problem.
Test plan
Before
Gallery examples didn't work on stackblitz, because only the example was checked out and not the whole repo
https://lexical.dev/gallery
After
Gallery examples work: https://lexical-git-fork-etrepum-fix-gallery-vite-config-fbopensource.vercel.app/gallery