Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[podspec] Build v0.4.x for macOS arm64 #351

Merged
merged 5 commits into from
Oct 8, 2020
Merged

[podspec] Build v0.4.x for macOS arm64 #351

merged 5 commits into from
Oct 8, 2020

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Sep 14, 2020 •
edited

Summary

Backports #345 to v0.4.x

Test Plan

Screenshot 2020-09-16 at 15 36 36

$ ditto --arch arm64 ./destroot/bin/hermesc ./destroot/bin/hermesc-arm64
$ file ./destroot/bin/hermesc-arm64 
./destroot/bin/hermesc-arm64: Mach-O 64-bit executable arm64
$ ./destroot/bin/hermesc-arm64 -version
LLVM (http://llvm.org/):
  LLVM version 8.0.0svn
  Optimized build

Hermes JavaScript compiler.
  Hermes release version: 0.4.3
  HBC bytecode version: 74

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 14, 2020
@tmikov
Copy link
Contributor

tmikov commented Sep 15, 2020

Note: this has to be merged manually.

@tmikov tmikov self-assigned this Sep 15, 2020
@alloy
Copy link
Contributor Author

alloy commented Sep 15, 2020

Hmm, interesting, looks like the build task staying quiet for a while leads to the CI task failing. Looking into it.

@alloy
[circle] Try to fix output timeout being hit
5c35a3e 
Do this by performing compilation step separately, because recursively
invoking cmake makes it go silent.
@alloy
[npm] Update instruction for manually buidling macOS artefacts
f39e713
@alloy
Copy link
Contributor Author

alloy commented Sep 15, 2020

Ok, looks like it’s building. I’ll test the artefacts tomorrow.

@alloy
Copy link
Contributor Author

alloy commented Sep 16, 2020

@tmikov @Huxpro Ok, this is good to go. Thanks a lot in advance! 🙏

@alloy alloy changed the title [HOLD] [podspec] Build for macOS arm64 [podspec] Build for macOS arm64 Sep 16, 2020
@alloy alloy changed the title [podspec] Build for macOS arm64 [podspec] Build v0.4.x for macOS arm64 Sep 16, 2020
@alloy alloy mentioned this pull request Oct 8, 2020
Closed
25 tasks
@alloy
Copy link
Contributor Author

alloy commented Oct 8, 2020

Bump, could we get a release of this for the macOS RN 0.63.x release?

appden
appden reviewed Oct 8, 2020
View reviewed changes
.circleci/config.yml
@@ -202,7 +202,7 @@ jobs:

macos:
macos:
xcode: "10.0.0"
xcode: "12.0.0-beta"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to the stable release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beta release needs to keep being used to build macOS arm64 binaries for Big Sur.

@tmikov tmikov merged commit 39ef157 into facebook:release-v0.4 Oct 8, 2020
@alloy alloy deleted the add-macOS-arm64-to-0.4 branch October 8, 2020 17:42
@Huxpro Huxpro self-assigned this Oct 22, 2020
@Huxpro
Copy link
Contributor

Huxpro commented Oct 22, 2020 •
edited

@alloy I had the same question for this one as for #390 so we can decide the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appden appden appden left review comments

Assignees

@Huxpro Huxpro

@tmikov tmikov

Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alloy @tmikov @Huxpro @appden @facebook-github-bot