fix(mdx-loader): Ignore contentTitle coming after Markdown thematicBreak #9999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fix shouldn't impact any user, apart some Meta OSS sites like React Native that decided to use
h1
headings in the middle of a doc (which doesn't look good, but it is the current state):Without this change, the
frontMatter.title
won't be injected as ah1
heading at the beginning of the doc (also called "synthetic heading" because it's not a Markdown# Title
)I don't really like to introduce such fancy edge case handling just for Meta sites, but the heuristic to ignore h1 after a thematic break still kind of makes sense for other sites, so if we can make it easier to upgrade to V3 Meta sites and it's not annoying for others, let's do it π€·ββοΈ
Test Plan
unit tests, React Native upgrade: facebook/react-native-website#4072
Test links
https://deploy-preview-9999--docusaurus-2.netlify.app/