Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx-loader): mdx-code-block should support CRLF #9897

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 29, 2024

Motivation

Fix #9896

Test Plan

Unit test

Also local testing. A page with CLRF was failing before the change was applied locally, and now it works:

CleanShot 2024-02-29 at 13 04 50

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 29, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

[V2]

Name Link
🔨 Latest commit 25fe5d1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65e0732ecfe8320008e373ec
😎 Deploy Preview https://deploy-preview-9897--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 53 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 58 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 68 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 60 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

Size Change: 0 B

Total Size: 992 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 765 kB
website/build/index.html 37.9 kB

compressed-size-action

@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Feb 29, 2024
@slorber slorber merged commit 2152572 into main Feb 29, 2024
34 checks passed
@slorber slorber deleted the slorber/unwrap-mdx-code-block-clrf branch February 29, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End-of-line CRLF sequence causes TabItem compilation error
2 participants