Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add heads up for Prettier users #9471

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Oct 30, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

#9318

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

Fix #9318

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 30, 2023
@netlify
Copy link

netlify bot commented Oct 30, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 43fee3c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/655f9999aa9c240008e1d29c
😎 Deploy Preview https://deploy-preview-9471--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 66 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 75 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 74 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 89 Report

@tats-u
Copy link
Contributor Author

tats-u commented Oct 30, 2023

Changed the version of MDX because of #9451

@tats-u tats-u requested a review from Josh-Cena October 30, 2023 14:48
@Josh-Cena Josh-Cena changed the title docs: Add heads up for Prettier users docs: add heads up for Prettier users Nov 23, 2023
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just been bitten by this recently. I think this helps users more than it harms us, and the wording is currently good enough, so I'm going to merge it. Thank you!

@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 23, 2023
@Josh-Cena Josh-Cena merged commit 6cc29fa into facebook:main Nov 23, 2023
9 checks passed
@tats-u tats-u deleted the prettier-mdx branch November 23, 2023 21:16
@tats-u
Copy link
Contributor Author

tats-u commented Jan 11, 2024

It looks like the content of this PR has not been merged into the 3.1.0 document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 doc: Prettier hasn't supported MDX v2 or v3 yet
3 participants