Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-classic): add description & keywords microdata to blog posts #9108

Merged
merged 2 commits into from Jun 29, 2023

Conversation

TheCatLady
Copy link
Contributor

@TheCatLady TheCatLady commented Jun 27, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

We're trying to improve SEO on our site and have implemented a similar change by swizzling the BlogPostItem/Container component.

Just thought it would be nice to get this minor change added to the official theme component for the benefit of all :)

Test Plan

Implemented on another Docusaurus site and verified with Google's schema markup testing tools.

Test links

Deploy preview: https://deploy-preview-9108--docusaurus-2.netlify.app/blog

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 27, 2023
@netlify
Copy link

netlify bot commented Jun 27, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e124e9a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/649cc03bdaf7ec000839972e
😎 Deploy Preview https://deploy-preview-9108--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 82 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 68 🟢 100 🟢 92 🟢 100 🟠 89 Report

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks 👍

@slorber slorber added pr: new feature This PR adds a new API or behavior. to backport This PR is planned to be backported to a stable version of Docusaurus labels Jun 29, 2023
@slorber slorber merged commit 05156d0 into facebook:main Jun 29, 2023
29 of 31 checks passed
@TheCatLady TheCatLady deleted the dh/blogmicrodata branch June 29, 2023 18:00
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. and removed pr: new feature This PR adds a new API or behavior. labels Sep 20, 2023
@slorber slorber changed the title feat(theme-classic): add description & keywords microdata to blog posts fix(theme-classic): add description & keywords microdata to blog posts Sep 20, 2023
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants