Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): only set classname on ul elements if they have an existing class #9099

Merged
merged 3 commits into from
Jun 30, 2023
Merged

fix(theme): only set classname on ul elements if they have an existing class #9099

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5e45e2
Only set classname on ul elements if they have an existing class.
homotechsual Jun 23, 2023
d03098f
Update packages/docusaurus-theme-classic/src/theme/MDXComponents/Ul/i…
slorber Jun 23, 2023
32869fd
proper fix
slorber Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/MDXComponents/Ul/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ import type {Props} from '@theme/MDXComponents/Ul';

import styles from './styles.module.css';

function transformUlClassName(className?: string): string {
function transformUlClassName(className?: string): string | undefined {
// Fix https://github.com/facebook/docusaurus/issues/9098
if (typeof className === 'undefined') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using typeof because if props.className is '' we probably still want to have class='' in the final html, although it's a weird edge-case

return undefined;
}
return clsx(
className,
// This class is set globally by GitHub/MDX. We keep the global class, and
Expand Down