-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): codeblock buttons should be kept on the right when using RTL locale #8803
Changes from 1 commit
8710dac
b1e4dcc
c08e3a7
90d9c36
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,3 +84,7 @@ | |
:global(.theme-code-block:hover) .buttonGroup button { | ||
opacity: 0.4; | ||
} | ||
|
||
.buttonBlockSpace { | ||
right: calc(var(--ifm-pre-padding) / 2) !important; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's not a good fix because our RTLCSS postCSS plugin will automatically transform If you test your dev locally The solution is to add an rtl ignore directive to avoid this auto transform to happen: .buttonGroup {
display: flex;
column-gap: 0.2rem;
position: absolute;
/* rtl:ignore */
right: calc(var(--ifm-pre-padding) / 2);
top: calc(var(--ifm-pre-padding) / 2);
} See directives syntax: https://rtlcss.com/learn/usage-guide/control-directives/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra class is not needed