fix(theme): light & dark mode checkbox doesn't announce state switches

[andrewasche]

Pre-flight checklist

• [X ] I have read the Contributing Guidelines on pull requests.
• If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
• If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

yarn start
open webpage and use nvda to test that the aria-pressed is saying if the button is pressed or if the button is not pressed

Test links

https://deploy-preview-10585--docusaurus-2.netlify.app/

[facebook-github-bot]

Hi @andrewasche!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ [V2]

Built without sensitive environment variables

Name	Link
🔨 Latest commit	9a5f81a
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/671139119fcfb600085580d4
😎 Deploy Preview	https://deploy-preview-10585--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	Report
/	🟠 80	🟢 98	🟢 96	🟢 100	Report
/docs/installation	🟠 58	🟢 97	🟢 100	🟢 100	Report
/docs/category/getting-started	🟠 73	🟢 100	🟢 100	🟠 86	Report
/blog	🟠 63	🟢 96	🟢 100	🟠 86	Report
/blog/preparing-your-site-for-docusaurus-v3	🔴 48	🟢 92	🟢 100	🟢 100	Report
/blog/tags/release	🟠 63	🟢 96	🟢 100	🟠 86	Report
/blog/tags	🟠 74	🟢 100	🟢 100	🟠 86	Report

[andrewasche]

I have completed the Contributor License Agreement after the workflow run into that issue. I couldn't figure out dogfooding either.

[slorber]

LGTM thanks

Apparently it's not really "needed" considering the aria-label is dynamic, but it also doesn't harm so let's merge it

[slorber]

In #10987 we are introducing a 3rd state to that button, with the ability to revert to system/os theme color mode. I'll have to remove this aria-pressed attribute.

Also i don't think we should have used it in the first place, it seems it leads VoiceOver to announce multiple times, see #7667 (comment)

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-pressed

Do not change the contents of the label on a toggle when the state changes. If a button label says "pause", do not change it to "play" when pressed. In this example, when the pressed state is true, the label remains "Pause" so a screen reader would say something like "Pause toggle button pressed".

If you want the label to toggle between "Paused" and "Play", don't use aria-pressed.

Since we are changing the icon, I believe it falls into that case, and we shouldn't use aria-pressed.