Issue #1608: use double for docker.cpus property #1609

vjuranek · 2022-09-27T08:19:18Z

Docker config option --cpus assumes float number, while current DMP docker.cpus assumes integer number, which is actually NanoCpus.

Change this property to double and convert it to NanoCpus before passing to Docker.

Signed-off-by: Vojtech Juranek vojtech.juranek@gmail.com

Fixes #1608

codecov · 2022-09-27T08:23:12Z

Codecov Report

Merging #1609 (cabcac4) into master (79a4a33) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1609      +/-   ##
============================================
+ Coverage     63.62%   63.65%   +0.02%     
- Complexity     2172     2173       +1     
============================================
  Files           170      170              
  Lines          9924     9923       -1     
  Branches       1359     1359              
============================================
+ Hits           6314     6316       +2     
+ Misses         3081     3078       -3     
  Partials        529      529

Impacted Files	Coverage Δ
...ic8/maven/docker/config/RunImageConfiguration.java	`90.90% <ø> (ø)`
...bric8/maven/docker/access/ContainerHostConfig.java	`92.66% <100.00%> (+0.20%)`	⬆️
...g/handler/compose/DockerComposeServiceWrapper.java	`61.19% <100.00%> (-0.76%)`	⬇️
...config/handler/property/PropertyConfigHandler.java	`85.90% <100.00%> (ø)`
.../docker/config/handler/property/ValueProvider.java	`86.40% <0.00%> (+2.40%)`	⬆️

vjuranek · 2022-09-27T10:47:38Z

I don't think test failures are related to this PR.

rohanKanojia · 2022-10-13T06:32:36Z

@vjuranek : Could you please add a line to doc/changelog regarding this change?

Docker config option `--cpus` assumes float number, while current DMP `docker.cpus` assumes integer number, which is actually `NanoCpus`. Change this property to `double` and convert it to `NanoCpus` before passing to Docker. Signed-off-by: Vojtech Juranek <vojtech.juranek@gmail.com>