cts/mts support #451
cts/mts support #451
Conversation
agilgur5
added
kind: feature
| @@ -95,8 +95,8 @@ const typescript: PluginImpl<RPT2Options> = (options) => | |||
| verbosity: VerbosityLevel.Warning, | |||
| clean: false, | |||
| cacheRoot: findCacheDir({ name: "rollup-plugin-typescript2" }), | |||
| include: ["*.ts+(|x)", "**/*.ts+(|x)"], | |||
There was a problem hiding this comment.
I think we need to modify the TS emit output conversion to also handle .d.cts, .d.mts and their respective mappings. I assume that TS would take a CTS file and output .cjs, d.cts, and d.cts.map files, which we would not handle correctly right now.
We should also definitely have integration tests for CTS / MTS, especially to validate that assumption above^
There was a problem hiding this comment.
Yeah it would fix #448 too
There was a problem hiding this comment.
Oh I didn't even think about that, but it would indeed fix #448. There is a slight problem there with declarations though; Rollup cannot convert them between .d.cts and .d.mts, so they are limited to the user's original module format. I'll detail that more in the issue itself.
There was a problem hiding this comment.
For the emit output conversion, I looked up the source code and indeed OutputFile now has some new extensions:
.mjs+.cjs.d.cts,.d.mts.mapfiles of those are just appended to the existing extension from above
I imagine that with module set to output ESM (for Rollup), we'd only see the .mjs variants, but testing can confirm that
Summary
Fix for #446
Details
Adding cts/mts to the known filetypes