Implement SecretExists in AWS ParameterStore #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ami Rahav <amirahav@users.noreply.github.com>
amirahav
force-pushed
the
implement-parameter-store-secret-exists
branch
from
0907db8 to
8625084
Compare
Skarlso
reviewed
Feb 4, 2025
| func (pm *ParameterStore) SecretExists(_ context.Context, _ esv1beta1.PushSecretRemoteRef) (bool, error) { | ||
| return false, errors.New("not implemented") | ||
| func (pm *ParameterStore) SecretExists(ctx context.Context, pushSecretRef esv1beta1.PushSecretRemoteRef) (bool, error) { | ||
| secretName := pushSecretRef.GetRemoteKey() |
There was a problem hiding this comment.
I think this should be secretName := pm.prefix + data.GetRemoteKey() since that's what PushSecret is pushing as a secret name.
There was a problem hiding this comment.
Should be fixed in the latest commit
Signed-off-by: Ami Rahav <amirahav@users.noreply.github.com>
amirahav
force-pushed
the
implement-parameter-store-secret-exists
branch
from
267f063 to
1c1e1b0
Compare
|
/ok-to-test sha=1c1e1b09ccfc8be0ca646b997c06f4a2c29631d3 provider=aws |
Skarlso
approved these changes
Feb 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
PushSecretwith AWS parameter store doesn't supportupdatePolicy: IfNotExistsRelated Issue
Fixes #...
Proposed Changes
This PR implements the
SecretExistsfunction withinParameterStoreto ensure that external secrets will only create the parameter if it doesn't exist in AWS.Checklist
git commit --signoffmake testmake reviewable