conditionally set headers (if not already set) in redirect response #190
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @wesleytodd, could you help with getting these changes checked? I think you mentioned something along these lines as potentially acceptable. I'm being pushed by security officer to have this fixed and closed. |
|
I am pretty sure I will be putting together a release for this in the coming days, so I will make sure this gets merged before then but I will leave it open so other contributors have a chance to see it again and provide any last minute feedback. |
|
fair enough, many thanks for coming back to me! :) |
UlisesGascon
approved these changes
Feb 17, 2025
|
@wesleytodd sorry for pushing, but is there any timeline on when the new release with this fix could be expected? |
Merged
Phillip9587
added a commit
to Phillip9587/serve-static
that referenced
this pull request
Mar 27, 2025
…ect response (expressjs#190)" This reverts commit b51ab84.
Phillip9587
pushed a commit
to Phillip9587/serve-static
that referenced
this pull request
Mar 27, 2025
…onse (expressjs#190) * conditionally set headers (if not already set) in redirect response * add new function description --------- Co-authored-by: ljeda <Lukasz.Jeda@pl.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggested fix for possibility to override default headers in redirect response.
fixes #187