Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (deps): update deps #6337

Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix (deps): update deps #6337

merged 1 commit into from
Feb 13, 2025

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Feb 13, 2025

Rebase and squash of the following dep update PRs from @agungjati:

fix(deps): mocha@^10.7.3 (closes #6121)

fix(deps): marked@^15.0.3 (closes #6120)

fix(deps): express-session@^1.18.1 (closes #6119)

fix(deps): ejs@^3.1.10 (closes #6117)

fix(deps): content-type@^1.0.5 (closes #6115)

fix(deps): connect-redis@^8.0.1 (closes #6114)

fix(deps): supertest@^6.3.4 (closes #6112)

Copy link

socket-security bot commented Feb 13, 2025

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/marked@15.0.7 🔁 npm/marked@15.0.3 None 0 968 kB tonybrix
npm/mocha@10.8.2 🔁 npm/mocha@10.2.0 None +69 5.19 MB voxpelli
npm/supertest@6.3.4 🔁 npm/supertest@6.3.0 Transitive: environment, filesystem +17 1.21 MB titanism

View full report↗︎

@bjohansebas
Copy link
Member

Interesting how in the individual PRs the tests were passing, and now they are not.

fix(deps): mocha@^10.7.3 (closes #6121)

fix(deps): marked@^15.0.3 (closes #6120)

fix(deps): express-session@^1.18.1 (closes #6119)

fix(deps): ejs@^3.1.10 (closes #6117)

fix(deps): content-type@^1.0.5 (closes #6115)

fix(deps): connect-redis@^8.0.1 (closes #6114)

fix(deps): supertest@^6.3.4 (closes #6112)
@wesleytodd
Copy link
Member Author

See: #6112 (comment)

It was supertest. I had forgotten I hit this before and it is why I had not updated it earlier.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleytodd
Copy link
Member Author

supertest issue: ladjs/supertest#851

@wesleytodd
Copy link
Member Author

Since each of these was approved individually and we waited the delay, going to land this.

@wesleytodd wesleytodd merged commit d2de128 into master Feb 13, 2025
21 of 23 checks passed
@bjohansebas bjohansebas deleted the dev-deps-grouped branch February 13, 2025 16:44
@bjohansebas bjohansebas mentioned this pull request Mar 15, 2025
@UlisesGascon UlisesGascon mentioned this pull request Mar 23, 2025
68 tasks
@wesleytodd wesleytodd mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants