Replace accepts with negotiator #197
Merged
+4
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeembrey
commented
Oct 24, 2024
| method = accept.encoding(['gzip', 'identity']) | ||
| } | ||
| var negotiator = new Negotiator(req) | ||
| var method = negotiator.encoding(['gzip', 'deflate', 'identity'], ['gzip']) |
There was a problem hiding this comment.
When you add brotli, just add it here:
Suggested change
| var method = negotiator.encoding(['gzip', 'deflate', 'identity'], ['gzip']) | |
| var method = negotiator.encoding(hasBrotli ? ['br', 'gzip', 'deflate', 'identity'] : ['gzip', 'deflate', 'identity'], hasBrotli ? ['br', 'gzip'] : ['gzip']) |
Edit: Could be better to store in global vars, e.g.
var SUPPORTED_ENCODING = hasBrotli ? ['br', 'gzip', 'deflate', 'identity'] : ['gzip', 'deflate', 'identity'];
var PREFERRED_ENCODING = hasBrotli ? ['br', 'gzip'] : ['gzip'];
bjohansebas
approved these changes
Oct 24, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #194 (comment).