Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modules-core] Add ExpoAppDelegate support for macOS #35061

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Feb 20, 2025

Why

In order for us to support macOS AppDelegate subscribers we must first support inheriting ExpoAppDelegate in macOS

How

  • Update modules-core to include macOS specific functions
  • Update BareExpo macOS to:
    • use swift AppDelegate
    • inherit from ExpoAppDelegate
    • Use Hermes
    • Run with new arch
    • metro config support react-native-macos out of the box

Test Plan

Run BareExpo macOS locally

Checklist

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
Copy link
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo/** @ide, @lukmccall, @brentvatne
packages/expo-modules-core/** @Kudo, @lukmccall

Generated by CodeMention

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Feb 20, 2025
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/macos-app-delegate branch from 1bb2351 to 118826d Compare February 20, 2025 13:04

# Set `REACT_NATIVE_PATH` to react-native-macos root node_modules
target_installation_result.native_target.build_configurations.each do |config|
config.build_settings["REACT_NATIVE_PATH"] = File.join("${PODS_ROOT}", "../../../../", 'node_modules/react-native-macos')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this hermes fails to build

@expo-bot
Copy link
Collaborator

expo-bot commented Feb 20, 2025

The Pull Request introduced fingerprint changes against the base commit: 30cef85

Fingerprint diff
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../node_modules/expo",
      "reasons": [
        "rncoreAutolinkingAndroid",
        "rncoreAutolinkingIos"
      ],
      "hash": "96881bef2291658d6f3e328c5a44627b99721d23"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../node_modules/expo",
      "reasons": [
        "rncoreAutolinkingAndroid",
        "rncoreAutolinkingIos"
      ],
      "hash": "a352be2af0c38996f9711e23eb8c5c0f206cea13"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins"
      ],
      "hash": "3a13828fb8ac6cae7776c21c56fc94d2416165cc"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins"
      ],
      "hash": "e151ade0cd8333a38c52609eef2ae61adb5814b3"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "6ed0b7880e4eecb293585b4aaf8d712c06332504"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "c9fc8203f17a6a10d5db3dcb03562806f9473e9f"
    }
  }
]

Generated by PR labeler 🤖

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 20, 2025
@gabrieldonadel gabrieldonadel merged commit 8c523c3 into main Feb 20, 2025
22 of 23 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/macos-app-delegate branch February 20, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants