-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modules-core] Add ExpoAppDelegate support for macOS #35061
Merged
Merged
+1,418
−533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribed to pull request
Generated by CodeMention |
1bb2351
to
118826d
Compare
gabrieldonadel
commented
Feb 20, 2025
|
||
# Set `REACT_NATIVE_PATH` to react-native-macos root node_modules | ||
target_installation_result.native_target.build_configurations.each do |config| | ||
config.build_settings["REACT_NATIVE_PATH"] = File.join("${PODS_ROOT}", "../../../../", 'node_modules/react-native-macos') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without this hermes fails to build
The Pull Request introduced fingerprint changes against the base commit: 30cef85 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "96881bef2291658d6f3e328c5a44627b99721d23"
},
"afterSource": {
"type": "dir",
"filePath": "../../node_modules/expo",
"reasons": [
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "a352be2af0c38996f9711e23eb8c5c0f206cea13"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "3a13828fb8ac6cae7776c21c56fc94d2416165cc"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoConfigPlugins",
"expoConfigPlugins"
],
"hash": "e151ade0cd8333a38c52609eef2ae61adb5814b3"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "6ed0b7880e4eecb293585b4aaf8d712c06332504"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "c9fc8203f17a6a10d5db3dcb03562806f9473e9f"
}
}
] Generated by PR labeler 🤖 |
alanjhughes
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In order for us to support macOS AppDelegate subscribers we must first support inheriting ExpoAppDelegate in macOS
How
react-native-macos
out of the boxTest Plan
Run BareExpo macOS locally
Checklist
changelog.md
entry and rebuilt the package sources according to this short guidenpx expo prebuild
& EAS Build (eg: updated a module plugin).