Introduce useEventListener hook
#32027
Merged
+81
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/use-event-listener
branch
from
5adb8f2 to
1666ee6
Compare
tsapeta
force-pushed
the
@tsapeta/use-event-listener
branch
from
1666ee6 to
4f500f6
Compare
|
Subscribed to pull request
Generated by CodeMention |
|
📘 Your docs preview website is ready! |
aleqsio
approved these changes
Oct 14, 2024
| @@ -15,7 +15,7 @@ | |||
| - Add initial version of DOM Components and `expo/dom` module. ([#30938](https://github.com/expo/expo/pull/30938) by [@EvanBacon](https://github.com/EvanBacon)) | |||
| - Support `URL.canParse`. ([#30697](https://github.com/expo/expo/pull/30697) by [@EvanBacon](https://github.com/EvanBacon)) | |||
| - Add minimal `TextDecoder` support to native client platforms. ([#29620](https://github.com/expo/expo/pull/29620) by [@EvanBacon](https://github.com/EvanBacon)) | |||
| - Introduced `useEvent` hook for EventEmitter objects (e.g. native modules and shared objects). ([#29056](https://github.com/expo/expo/pull/29056) by [@tsapeta](https://github.com/tsapeta)) | |||
| - Introduced `useEvent` and `useEventListener` hooks for EventEmitter objects (e.g. native modules and shared objects). ([#29056](https://github.com/expo/expo/pull/29056), [#32027](https://github.com/expo/expo/pull/32027) by [@tsapeta](https://github.com/tsapeta)) | |||
There was a problem hiding this comment.
🤨 Why not a new changelog entry?
There was a problem hiding this comment.
I just thought that since the useEvent hasn't been published yet, I can merge them as they are related. It seems better for someone who reads the changelog.
lukmccall
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
useEventis sometimes not enough, especially when the event has no payload or we don't want to use the payload as a component's state but just react to the event.How
Introduced
useEventListenerhook, as an alternative version. Also,useEventwill now use it under the hood.Test Plan
useEventusages in NCL (onlyexpo-videoright now) work as expecteduseEffectthat adds and removes the listener with the newuseEventListener