[expo]: Add types folder to published package

[marklawlor]

Why

Add types folder to package.json. This folder should be included for better typing in Expo Web.

Running the CLI with TypeScript enabled will create a expo-env.d.ts that references this folder. This has gone unnoticed as there is no warning/error and these types are additive (and also supplied by router) but VS Code now has a warning that the folder is missing.

Fixes #31250

How

Test Plan

Checklist

• Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
• Conforms with the Documentation Writing Style Guide
• This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

[expo-bot]

The Pull Request introduced fingerprint changes against the base commit: df216d9

Fingerprint diff

[
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../node_modules/expo",
      "reasons": [
        "bareRncliAutolinking"
      ],
      "hash": "41d8db5d77625f15779c4d1ded50d4a28736a822"
    }
  },
  {
    "op": "changed",
    "source": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins"
      ],
      "hash": "a34dbe8f85b79ebb2d509e5009e10f70e7c5bf58"
    }
  }
]

---

Generated by PR labeler 🤖

[Kudo]

looks good to me but @byCedric mentioned some concern that whether these types are internal and should not publish publicly. please double check if we need all these types publicly. see https://exponent-internal.slack.com/archives/C5ERY0TAR/p1725439343314989?thread_ts=1725411493.294319&cid=C5ERY0TAR

[marklawlor]

I don't consider any of these types internal. These are not types for the expo package. They just improve the types of the existing user environment. This should only affect existing globals (require()) or imports from react-native-web

[Kudo]

I don't consider any of these types internal. These are not types for the expo package. They just improve the types of the existing user environment. This should only affect existing globals (require()) or imports from react-native-web

it looks like we've tried to override react-native types:

expo/packages/expo/types/react-native-web.d.ts

Line 4 in a3da817

declare module 'react-native' {

not sure if that would conflict with react-native types?

[marklawlor]

@Kudo You cannot override with TypeScript, interfaces are always merged. If there is a conflict (e.g impossible to satisfy unions), TypeScript will error and fail to compile.

For example, with these changes ViewProps will be a union of the published types and our definitions.

[Kudo]

cool, thanks for clarifying that.