[expo-updates] Migrate to requireNativeModule/requireOptionalNativeModule #25648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
requested review from
ide,
tsapeta,
brentvatne and
douglowder
as code owners
wschurman
force-pushed
the
@wschurman/migrate-native-modules-proxy
branch
from
97d0dc1
to
4767207
Compare
douglowder
approved these changes
Nov 29, 2023
ide
approved these changes
Nov 29, 2023
tsapeta
approved these changes
Nov 30, 2023
This was referenced Dec 5, 2023
wschurman
force-pushed
the
@wschurman/migrate-native-modules-proxy
branch
from
4767207
to
da36ada
Compare
wschurman
force-pushed
the
@wschurman/migrate-native-modules-proxy
branch
from
da36ada
to
c6ba68f
Compare
expo-bot
added
bot: passed checks
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This converts the cross-module requires of expo-updates to use the new functions.
Not sure we'll be able to land this for a while since it's more a feature than a bugfix and is a bit risky. But I figured I'd put up the PR anyways.
How
Convert, following patterns from elsewhere.
Test Plan
Wait for all tests in CI.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).