[dev-client][splash-screen] Fix error when running with new arch mode on android #19931
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
lukmccall
approved these changes
Nov 8, 2022
tsapeta
pushed a commit
that referenced
this pull request
Nov 8, 2022
3 tasks
gabrieldonadel
added a commit
that referenced
this pull request
May 23, 2023
# Why Closes ENG-7955 # How Implement the missing `getJSIModulePackage` methods to both `ReactNativeHost`s in order to support the new architecture. `ReactPackageTurboModuleManagerDelegate` was already implemented on #19931 # Test Plan Run `fabric-tester` and `bare-expo` apps on Android # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
when turning on new architecture mode with dev-client, there is a runtime crash:
fixes #19866
How
react-native has a singleton flag
ReactFeatureFlags.useTurboModules. even though we have theReactNativeHostwith old architecture mode in dev-menu and dev-launcher, the underlyingCatalystInstanceImplwill still fail at the check. theReactPackageTurboModuleManagerDelegate.Builderrequires some c++ code, considering we don't support new architecture mode in dev-menu and dev-launcher, this pr uses a workaround to pass theReactPackageTurboModuleManagerDelegate.Builderfrom MainApplication.when running on new architecture mode, there is a NPE in
FrameLayout.onMeasure. since splash screen view remove itself inViewGroup.OnHierarchyChangeListener. the child iteration will get null fromgetChildAt(). the pr tries to remove the splash screen view from the next run loop.Test Plan
Checklist
expo prebuild& EAS Build (eg: updated a module plugin).