Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sphinx 7 and onwards #131

Closed
wants to merge 4 commits into from

Conversation

LecrisUT
Copy link

@LecrisUT LecrisUT commented Jun 17, 2023

Closes #130

@welcome
Copy link

welcome bot commented Jun 17, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@LecrisUT
Copy link
Author

Actually all tests are passing on my fork 🎉 LecrisUT#1

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (537e0d0) 89.97% compared to head (454dd84) 89.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #131   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files          11       11           
  Lines         948      948           
=======================================
  Hits          853      853           
  Misses         95       95           
Flag Coverage Δ
pytests 89.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FloLey
Copy link

FloLey commented Jun 23, 2023

@choldgraf in case you missed it and sorry for the ping if you are not the one I should have pinged :)

FloLey added a commit to inmanta/inmanta-dev-dependencies that referenced this pull request Jun 27, 2023
sphinx conflicts with sphinx-design and we are waiting on: executablebooks/sphinx-design#131
@michaelweinold
Copy link

Hello, hello! Any update on this?

@AA-Turner
Copy link

@chrisjsewell -- sorry for the ping, would it be possible to look at this PR to support Sphinx 7 in sphinx-design please? From my perspective all seems fine, but I'm not sure who has permissions to do a release on the executable books team.

Thanks,
Adam

@chrisjsewell
Copy link
Member

superceded by #148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Sphinx 7
5 participants