Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX empty value for final directive option #924

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

chrisjsewell
Copy link
Member

fixes #923

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (c9579c4) to head (b1e243b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files          24       24           
  Lines        3415     3416    +1     
=======================================
+ Hits         3078     3079    +1     
  Misses        337      337           
Flag Coverage Δ
pytests 90.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell merged commit 446feba into master Apr 28, 2024
20 checks passed
@chrisjsewell chrisjsewell deleted the fix-options branch April 28, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For v3.0.1: If the last directive option has an empty value then it is omitted
2 participants