-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 Add additional Ruff lints (and fix issues) #862
🔧 Add additional Ruff lints (and fix issues) #862
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 24 24
Lines 3372 3373 +1
=======================================
+ Hits 3037 3038 +1
Misses 335 335
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[tool.ruff.per-file-ignores] | ||
"myst_parser/parsers/docutils_.py" = ["FA"] | ||
"myst_parser/config/main.py" = ["FA"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is logic in these files currently utilises runtime analysis of types, so you can't have postponed evaluation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hope you don't mind, but I was impatient and fixed the issues causing your changes to fail CI
Actually, I also reverted https://docs.astral.sh/ruff/rules/missing-trailing-comma/; I don't think it integrates well with the ruff formatter, in particular https://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma (see also https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#the-magic-trailing-comma) |
lints are in separate commits for ease of reviewing (not every one of these lints will necessarily be of interest)