Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Add linkify dependency to contributing docs. #792

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

jhcole
Copy link
Contributor

@jhcole jhcole commented Jul 20, 2023

Fix #791

@welcome
Copy link

welcome bot commented Jul 20, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

Copy link
Member

@chrisjsewell chrisjsewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers!

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f03f5c) 90.26% compared to head (2665844) 90.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   90.26%   90.26%           
=======================================
  Files          23       23           
  Lines        2970     2970           
=======================================
  Hits         2681     2681           
  Misses        289      289           
Flag Coverage Δ
pytests 90.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chrisjsewell chrisjsewell changed the title Add linkify dependency to contributing docs. 📚 Add linkify dependency to contributing docs. Jul 20, 2023
@chrisjsewell chrisjsewell merged commit 350c633 into executablebooks:master Jul 20, 2023
21 checks passed
@welcome
Copy link

welcome bot commented Jul 20, 2023

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

n-peugnet added a commit to n-peugnet/MyST-Parser that referenced this pull request Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install step does not include linkify dependency
2 participants