Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding partial group to frame #9014

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

ryan-di
Copy link
Member

@ryan-di ryan-di commented Jan 15, 2025

When drag creating a new frame, do not add a partial group to it.

When wrapping a selected partial group in a frame however, do add it to the wrapping frame. But we should separate it from the previous containing group.

close #9008

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Jan 15, 2025 0:46am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Jan 15, 2025 0:46am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Jan 15, 2025 0:46am
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 15, 2025 0:46am

Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 66.83% (🎯 60%) 67336 / 100743
🟢 Statements 66.83% (🎯 60%) 67336 / 100743
🟢 Functions 63.88% (🎯 63%) 1951 / 3054
🟢 Branches 79.59% (🎯 70%) 8041 / 10103
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/excalidraw/frame.ts 69.12% 79.43% 79.31% 69.12% 47-62, 109-116, 169-187, 190-210, 218-231, 286, 304-315, 318-331, 352-361, 369-381, 384-422, 432, 519-520, 534-535, 545, 547-548, 579-593, 596-603, 644-653, 665-666, 670-671, 703-704, 728, 746, 764-770, 772-801, 808-809
packages/excalidraw/actions/actionFrame.ts 38.96% 100% 45.45% 38.96% 34-61, 71-92, 103-114, 125-144, 165-212
Generated in workflow #4123 for commit 523f790 by the Vitest Coverage Report Action

@ryan-di ryan-di requested a review from dwelle January 15, 2025 21:50
@ryan-di ryan-di merged commit 0bf234f into master Jan 22, 2025
10 checks passed
@ryan-di ryan-di deleted the ryan-di/frame-partial-group-fix branch January 22, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partial groups shouldn't be allowed to be added to frames
2 participants