-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Comic Shanns issues, new fonts structure #8641
Merged
Merged
+13,267
−488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
9a9b505
to
1c021f0
Compare
1c021f0
to
8b8e73e
Compare
8b8e73e
to
edbe689
Compare
d429207
to
c1c5900
Compare
d25a4b4
to
6243d1b
Compare
6243d1b
to
4d54c93
Compare
Loading status checks…
…t tests
4d54c93
to
eeb98b0
Compare
dwelle
approved these changes
Oct 20, 2024
Thanks, we're good to go! |
This was referenced Oct 21, 2024
Closed
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Jauhen
pushed a commit
to Jauhen/excalidraw
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8327
Adopted https://github.com/jesusmgg/comic-shanns-mono with few modifications:
tumed question mark
glyphAlso done:
excalidraw-app
, OSS package (host apps, examples, E+), and CDN intofonts/[FontFamilyName]/[FontFamilyName]-*.woff2
EXCALIDRAW_ASSET_PATH
for OSS and E+ ✅ (instead of one relying on "/" while the other on "/fonts/")excalidraw-app/build
&excalidraw/dist/prod/
intofonts/
folder ✅ (instead of having all on root)-[hash]
suffix to fonts onexcalidraw-app
build (we have hashes thanks to the split)Fixes:
Todo: