Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reimplement rectangle intersection #8367

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Conversation

mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented Aug 12, 2024

Quickfix for faulty rectangular shape <-> segment intersection calculation

Verified

This commit was signed with the committer’s verified signature.
mtolmacs Márk Tolmács

Verified

This commit was signed with the committer’s verified signature.
mtolmacs Márk Tolmács
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview Aug 12, 2024 1:35pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview Aug 12, 2024 1:35pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview Aug 12, 2024 1:35pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 12, 2024 1:35pm

Verified

This commit was signed with the committer’s verified signature.
mtolmacs Márk Tolmács

Verified

This commit was signed with the committer’s verified signature.
mtolmacs Márk Tolmács
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 66.57% (🎯 70%) 58068 / 87218
🔴 Statements 66.57% (🎯 70%) 58068 / 87218
🟢 Functions 68.23% (🎯 68%) 1727 / 2531
🟢 Branches 81% (🎯 70%) 7273 / 8978
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/excalidraw/element/binding.ts 90.24% 88.05% 95.71% 90.24% 264, 280, 310, 320, 362-363, 597-598, 718-721, 790, 797-799, 802-835, 845-858, 862-875, 879-901, 905-921, 949-950, 952-954, 966-979, 992, 994-995, 1003-1008, 1048, 1200-1201, 1209-1210, 1215-1216, 1257, 1269-1270, 1295-1296, 1723-1724, 1751-1752, 1774-1775, 1827-1829, 2008-2009, 2120-2121, 2153-2157, 2187-2219, 2222-2231
packages/utils/geometry/geometry.ts 51.6% 93.47% 50% 51.6% 37-42, 72-74, 109-114, 134-137, 141-144, 148-152, 164-165, 168-173, 178-180, 183-226, 229-230, 233-248, 251-288, 291-338, 341-353, 360-365, 368-398, 401-420, 423-442, 445-465, 468-488, 491-509, 512-530, 533-538, 545-558, 561-564, 567-592, 689-690, 697-698, 717-734, 737-771, 859-879, 882-909
Generated in workflow #3067

Copy link
Member

@dwelle dwelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dwelle dwelle merged commit 8420e1a into master Aug 12, 2024
10 checks passed
@dwelle dwelle deleted the fix/patch-intersect-2 branch August 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants