You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support to customize grid step (the bold lines). We could allow customizing grid cell size (currently 20px), but it feels less useful and I don't think it was ever even requested, so for simplicity's sake, we're not allowing it that now.
support for customizing gridStep from the stats menu (tracked as appState.gridStep, previously hardcoded). Clamped to <1, 100>, integer.
shows gridStep input in Stats only when grid mode enabled
divorced gridSize from enabled state, which is now tracked separately as appState.gridModeEnabled
fixed grid rendering to work with arbitrary integer gridSize & gridStep
props.gridModeEnabled is now independent from appState and doesn't override it (previously it was overriding gridSize)
grid lines rendering more crisp when 100% zoom
grid step lines not rendered when gridStep=1
grip lines not rendered when too small (on small zoom)
Stats <DragInput> now also takes sensitivity to allow to reduce pointer px sensitivity
gridSize, gridStep, and zoom.value now properly normalized on restore
When shift dragging, i.e. changing the grid steps by a step size of 5, I find it to be a bit too "sensitive" still. In the context of grids, changing gridStep by 5 changes the side length of the "grid box" by 100 and the area of the "grid box" actually changes exponentially.
We could either reduce the step size or take both sensitivity and step size into account so that sensitivity gets reduced when shift dragged. But this is really minor and probably not worth fussing over atm.
When shift dragging, i.e. changing the grid steps by a step size of 5, I find it to be a bit too "sensitive" still. In the context of grids, changing gridStep by 5 changes the side length of the "grid box" by 100 and the area of the "grid box" actually changes exponentially.
We could either reduce the step size or take both sensitivity and step size into account so that sensitivity gets reduced when shift dragged. But this is really minor and probably not worth fussing over atm.
Yeah, though it would require props.sensitivity to be a function that gets passed whether it's a step-based interaction, which IMO not worth it as you say, since even the dragging itself on this property is not going to be that common use case.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8244
Adding support to customize grid step (the bold lines). We could allow customizing grid cell size (currently 20px), but it feels less useful and I don't think it was ever even requested, so for simplicity's sake, we're not allowing it that now.
gridStepfrom the stats menu (tracked asappState.gridStep, previously hardcoded). Clamped to<1, 100>, integer.gridStepinput in Stats only when grid mode enabledgridSizefrom enabled state, which is now tracked separately asappState.gridModeEnabledgridSize&gridStepprops.gridModeEnabledis now independent fromappStateand doesn't override it (previously it was overridinggridSize)gridStep=1<DragInput>now also takessensitivityto allow to reduce pointer px sensitivitygridSize,gridStep,andzoom.valuenow properly normalized on restoreround(value, precision)