Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add very minimal linting #894

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Add very minimal linting #894

merged 3 commits into from
Jan 18, 2024

Conversation

itamarst
Copy link
Contributor

Doesn't lint eventlet/green/ and has a very restricted set of lints, but better than nothing.

@itamarst itamarst linked an issue Jan 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8d781c2) 55% compared to head (dd4c333) 56%.

Files Patch % Lines
eventlet/zipkin/api.py 0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #894    +/-   ##
======================================
  Coverage      55%    56%            
======================================
  Files          90     89     -1     
  Lines        9880   9717   -163     
  Branches     1832   1810    -22     
======================================
- Hits         5460   5457     -3     
+ Misses       4045   3885   -160     
  Partials      375    375            
Flag Coverage Δ
ipv6 23% <0%> (+<1%) ⬆️
py310asyncio 53% <33%> (+<1%) ⬆️
py310epolls 53% <33%> (+<1%) ⬆️
py310poll 53% <33%> (+<1%) ⬆️
py310selects 53% <33%> (+<1%) ⬆️
py311asyncio 53% <33%> (+<1%) ⬆️
py311epolls 53% <33%> (+<1%) ⬆️
py312asyncio 50% <33%> (+<1%) ⬆️
py312epolls 51% <33%> (+<1%) ⬆️
py37asyncio 50% <33%> (+<1%) ⬆️
py37epolls 51% <33%> (+<1%) ⬆️
py38asyncio 51% <33%> (?)
py38epolls 53% <33%> (+<1%) ⬆️
py38openssl 52% <33%> (+<1%) ⬆️
py38poll 53% <33%> (+<1%) ⬆️
py38selects 53% <33%> (+<1%) ⬆️
py39asyncio 51% <33%> (+<1%) ⬆️
py39dnspython1 51% <33%> (+<1%) ⬆️
py39epolls 53% <33%> (+<1%) ⬆️
py39poll 53% <33%> (+<1%) ⬆️
py39selects 53% <33%> (+<1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itamarst itamarst requested a review from a team January 16, 2024 21:44
Copy link
Member

@4383 4383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch, I think some parts needs changes, see my inline comments.

eventlet/backdoor.py Show resolved Hide resolved
eventlet/wsgi.py Outdated Show resolved Hide resolved
eventlet/zipkin/api.py Show resolved Hide resolved
eventlet/zipkin/api.py Show resolved Hide resolved
tests/greenpool_test.py Show resolved Hide resolved
tests/ssl_test.py Show resolved Hide resolved
@itamarst itamarst requested a review from 4383 January 18, 2024 13:38
@4383 4383 merged commit c36286f into master Jan 18, 2024
30 of 31 checks passed
@4383 4383 deleted the 893-add-minimal-linting branch January 18, 2024 15:22
@4383 4383 mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimal linting
3 participants