Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic documentation for asyncio migration #892

Conversation

itamarst
Copy link
Contributor

No description provided.

@itamarst itamarst requested a review from a team January 16, 2024 21:03
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d781c2) 55% compared to head (02613dd) 55%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #892   +/-   ##
=====================================
  Coverage      55%    55%           
=====================================
  Files          90     90           
  Lines        9880   9880           
  Branches     1832   1832           
=====================================
  Hits         5460   5460           
  Misses       4045   4045           
  Partials      375    375           
Flag Coverage Δ
ipv6 22% <ø> (ø)
py310asyncio 52% <ø> (ø)
py310epolls 52% <ø> (+<1%) ⬆️
py310poll 52% <ø> (ø)
py310selects 52% <ø> (ø)
py311asyncio 52% <ø> (-1%) ⬇️
py311epolls 52% <ø> (ø)
py312asyncio 49% <ø> (-1%) ⬇️
py312epolls 50% <ø> (+<1%) ⬆️
py37asyncio 49% <ø> (ø)
py37epolls 50% <ø> (+<1%) ⬆️
py38asyncio 50% <ø> (?)
py38epolls 52% <ø> (ø)
py38openssl 51% <ø> (ø)
py38poll 52% <ø> (ø)
py38selects 52% <ø> (-1%) ⬇️
py39asyncio 50% <ø> (+<1%) ⬆️
py39dnspython1 50% <ø> (+<1%) ⬆️
py39epolls 52% <ø> (-1%) ⬇️
py39poll 52% <ø> (-1%) ⬇️
py39selects 52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@4383 4383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Globally this PR LGTM, I just have some suggestions and questions inline.

doc/source/migration.rst Outdated Show resolved Hide resolved
doc/source/migration.rst Show resolved Hide resolved
doc/source/migration.rst Outdated Show resolved Hide resolved
doc/source/migration.rst Show resolved Hide resolved
doc/source/migration.rst Outdated Show resolved Hide resolved
@4383 4383 added the doc label Jan 18, 2024
@itamarst itamarst requested a review from 4383 January 18, 2024 13:52
Copy link
Member

@4383 4383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, thank you @itamarst

@4383
Copy link
Member

4383 commented Jan 18, 2024

Would be worth publishing this doc with tag 0.35.0

@4383 4383 merged commit 387ca4b into master Jan 18, 2024
31 checks passed
@4383 4383 deleted the 891-document-asyncio-integration-and-how-to-use-it-for-migration-path-off-of-eventlet branch January 18, 2024 15:37
@4383 4383 mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document asyncio integration and how to use it for migration path off of eventlet
3 participants