Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2388: allow consuming types without dom types #3679

Merged
merged 3 commits into from
Mar 7, 2024
Merged

fix #2388: allow consuming types without dom types #3679

merged 3 commits into from
Mar 7, 2024

Commits on Mar 5, 2024

  1. fix evanw#2388: allow consuming types without dom types 

    Currently the TypeScript types for esbuild depend on the DOM types.
However, esbuild itself does not depend on the DOM.

This change uses type augmentation to make the type error go away, while
keeping backwards support for use with the DOM types.

Closes evanw#2388
    @remcohaszing
    remcohaszing committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    6f2f66d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. add tests and comments

    @evanw
    evanw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    999f1fb View commit details
    Browse the repository at this point in the history

  2. remove unnecessary declare module 'esbuild'

    @evanw
    evanw committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    a526b14 View commit details
    Browse the repository at this point in the history