Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump go version to 1.21.0 #4250

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

notanatol
Copy link
Contributor

@notanatol notanatol commented Aug 8, 2023

Checklist

Description

Go 1.21.0 is out so starting a PR to keep bee up to date.

Linked to #3927

@notanatol notanatol marked this pull request as draft August 8, 2023 17:01
@notanatol notanatol added the on hold Temporarily halted by other development label Aug 8, 2023
@notanatol notanatol changed the base branch from master to chore-upgrade-libp2p-v26 August 19, 2023 07:31
@notanatol notanatol changed the base branch from chore-upgrade-libp2p-v26 to master August 19, 2023 07:52
@notanatol notanatol changed the base branch from master to chore-upgrade-libp2p-v26 August 20, 2023 10:03
@notanatol notanatol self-assigned this Aug 20, 2023
@notanatol notanatol added ready for review The PR is ready to be reviewed and removed on hold Temporarily halted by other development labels Aug 20, 2023
@notanatol notanatol marked this pull request as ready for review August 20, 2023 10:04
@@ -10,11 +10,12 @@ import (
"fmt"
"testing"

"slices"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the upper group. The same below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the gofumpt formatter and they got re-arranged now

pkg/storer/internal/chunkstore/recovery_test.go Outdated Show resolved Hide resolved
pkg/topology/mock/mock.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@notanatol notanatol force-pushed the chore-upgrade-libp2p-v26 branch 2 times, most recently from 1f6e7a4 to 17d07dc Compare September 8, 2023 06:19
@mrekucci mrekucci merged commit 66a7805 into chore-upgrade-libp2p-v26 Oct 16, 2023
13 checks passed
@mrekucci mrekucci deleted the bump-go-1.21 branch October 16, 2023 12:23
mrekucci pushed a commit that referenced this pull request Oct 16, 2023
mrekucci pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull-request ready for review The PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants