ethdb/pebble: use consistent write option for pebble update #29113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is almost certainly wrong. There are reasons why certain flags are used in certain places and just blindly updating it with no rational is almost surely wrong. |
|
I think nil defaults to non-sync mode, and the adjustment is to use writeoption, which generally only has stronger consistency guarantees. Currently, sync mode is used by default elsewhere to ensure stronger consistency(fsync is now enabled for pebble database writes (#27615, #27522)). Is this the only place that is not in sync mode to improve performance? I will close this PR for now~ :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep a consistent write option with put/delete/batch-write.