Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/rlpdump: add -pos flag, displaying byte positions #28785

Merged
merged 1 commit into from Jan 14, 2024
Merged

cmd/rlpdump: add -pos flag, displaying byte positions #28785

merged 1 commit into from Jan 14, 2024

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Jan 10, 2024 •
edited 

go run ./cmd/rlpdump -pos cmd/devp2p/internal/ethtest/testdata/chain.rlp 
     0: [
     3:   [
     6:     3d35e0b689cdd20720592d9a4d0d208de0612ebcb46e391141501e7d55d55b42,
    39:     1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347,
    72:     0000000000000000000000000000000000000000,
    93:     e2eb6472cb1addc491bcf24dca5bc93e8a1feb5280793be6583e82fea2820772,
   126:     8f3b22c4b001b4062f9430d885cf4dba33a3b086ada9e7768ecfe90b14df1ca1,
   159:     b81239ff8b0e3bcb4b3b347b27f1236648dd4427e3e93c51e1144997d114ced2,
   192:     00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000,
   451:     020000,
   455:     01,
   456:     023f3e20,
   461:     0102d3,
   465:     0a,
   466:     "",
   467:     0000000000000000000000000000000000000000000000000000000000000000,
   500:     0000000000000000,
   509:   ],
   509:   [
   511:     [
   513:       "",
   514:       01,
   515:       010508,
   519:       "",
   ...

holiman
holiman approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit 1485814 into ethereum:master Jan 14, 2024
1 of 3 checks passed
@fjl fjl added this to the 1.13.11 milestone Jan 14, 2024
@dnhn dnhn mentioned this pull request Jan 24, 2024
Merged
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@fjl @Dergarcon
cmd/rlpdump: add -pos flag, displaying byte positions (ethereum#28785)
9add937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fjl @holiman