Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethdb, internal/ethapi: support exposing Pebble stats too, beside LevelDB #28224

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

karalabe
Copy link
Member

LevelDB has a method exposed via the API to expose all internal counters. This is rarely useful to debug things.

With the current Pebble issues, turns out Pebble also has a similar mechanism, but unfortunately we never exposed it. This PR exposes it.

@karalabe karalabe added this to the 1.13.3 milestone Sep 28, 2023
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm

@karalabe karalabe merged commit f988b23 into ethereum:master Sep 28, 2023
1 of 2 checks passed
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
…elDB (ethereum#28224)

ethdb, internal/ethapi: support exposing Pebble stats too, besinde LevelDB
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
…elDB (ethereum#28224)

ethdb, internal/ethapi: support exposing Pebble stats too, besinde LevelDB
0x366 pushed a commit to Dexcelerate/go-ethereum that referenced this pull request Nov 8, 2023
…elDB (ethereum#28224)

ethdb, internal/ethapi: support exposing Pebble stats too, besinde LevelDB
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…elDB (ethereum#28224)

ethdb, internal/ethapi: support exposing Pebble stats too, besinde LevelDB
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants