core/forkid: add forkid test for holesky #28193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
karalabe,
holiman and
rjl493456442
as code owners
karalabe
reviewed
Sep 25, 2023
| {123, 0, ID{Hash: checksumToBytes(0xc61a6098), Next: 1696000704}}, // First MergeNetsplit block | ||
| {123, 1696000704, ID{Hash: checksumToBytes(0xfd4f016b), Next: 0}}, // Last MergeNetsplit block | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Hmm, block numbers feel wonky. Wondering if we could somehow not have to specify them? Just a thought.
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 9, 2023
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
siosw
pushed a commit
to SpecularL2/go-ethereum
that referenced
this pull request
Oct 16, 2023
0x366
pushed a commit
to Dexcelerate/go-ethereum
that referenced
this pull request
Nov 8, 2023
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 5205143.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 5205143.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 5205143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a forkid test, matching besu & nethermind