Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: eth_call block parameter is optional #28165

Merged
merged 2 commits into from Sep 26, 2023

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Sep 20, 2023

So apparently in the spec the base block parameter of eth_call is optional. I agree that "latest" is a sane default for this that most people would use.

@jsvisa
Copy link
Contributor

jsvisa commented Sep 20, 2023

In the spec, there seem more methods that also mark block as optional:

  • eth_getBalance
  • eth_getStorageAt
  • eth_getTransactionCount
  • eth_getCode

But curious, eth_getProof mark block as required.

@fjl fjl changed the title internal/ethapi: eth_call block to be optional internal/ethapi: eth_call block parameter is optional Sep 26, 2023
@fjl fjl merged commit adb9b31 into ethereum:master Sep 26, 2023
1 of 2 checks passed
@fjl fjl added this to the 1.13.2 milestone Sep 26, 2023
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 9, 2023
So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.
siosw pushed a commit to SpecularL2/go-ethereum that referenced this pull request Oct 16, 2023
So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.
0x366 pushed a commit to Dexcelerate/go-ethereum that referenced this pull request Nov 8, 2023
So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
So apparently in the spec the base block parameter of eth_call is optional.
I agree that "latest" is a sane default for this that most people would use.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Feb 26, 2024
internal/ethapi: eth_call block parameter is optional (ethereum#28165)

 Conflicts:
	internal/ethapi/api.go
api: conflict because we added a param to DoCall, accept both changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants