core/forkid: skip genesis forks by time

[lightclient]

I made a mistake in #27895, I didn't realize newFilter also generated the fork id hash. This caused geth to disconnect from peers during the handshake. I've resolved it by modifying gatherForks to simply skip forks that are non-zero and before the genesis timestamp.

[holiman]

I think the API is a bit clunky.

func NewID(config *params.ChainConfig, genesis *types.Block, head, time uint64) ID 

The genesis is a *types.Block, but really all we need is *types.Header, to internally check Hash() and Time()
The head, time are uint64, but in reality, nearly [1] all callers have a head *types.Header already, and picks out the individual fields to pass in.

IMO a better api would be

func NewID(config *params.ChainConfig, genesis, head *types.Header) ID 

[1]: The callsite cmd/devp2p/internal/ethtest/chain.go does something very wonky, passing in the genesis time:

// ForkID gets the fork id of the chain.
func (c *Chain) ForkID() forkid.ID {
	return forkid.NewID(c.chainConfig, c.blocks[0], uint64(c.Len()), c.blocks[0].Time())
}

It looks like it should be

// ForkID gets the fork id of the chain.
func (c *Chain) ForkID() forkid.ID {
	return forkid.NewID(c.chainConfig, c.blocks[0], uint64(c.Len()), c.blocks[c.Len() -1].Time())
}

Just the type of error that would not have happened with my suggested api :)
Don't have to be done in this PR, if this is a bugfix.

[holiman]

You also added a genesis.json file, is that intentional?

[holiman]

I think the API is a bit clunky.

@karalabe says to leave it as is (triage discussion)

[lightclient]

You also added a genesis.json file, is that intentional?

not intentional! removed

[lightclient]

Should be okay now. Sorry for all the back and forth, brain was a little fried last week.

[holiman]

LGTM

[ismaelapariciojr]

Thanks for merging #28034 into master! Can you please provide an update on the status of this PR?

…

On Mon, Sep 04, 2023 09:32 AM, ***@***.*** wrote: Merged #28034 <#28034> into master. — Reply to this email directly, view it on GitHub <#28034 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AV75GPTCEMAKDHG2D6RSRDDXYXJ6XANCNFSM6AAAAAA4FI65MU> . You are receiving this because you commented.Message ID: ***@***.***>

[ismaelapariciojr]

wallet_2