eth/catalyst: disable full payload when not in dev mode #27921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
changed the title
|
I changed the title to make it not seem like a change that only concerned dev-mode |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
eth/catalyst: only enable full payload in dev mode
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27921)" This reverts commit 1e72cdb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27921)" This reverts commit 1e72cdb.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…reum#27921)" This reverts commit 1e72cdb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in engine API. GetPayload supports two mode: full or non-full.
In full mode, GetPayload will block until a full block is generated
("full block" doesn't mean it must include transaction, but it will try to pack as many transactions
as possible into block).
In non-full mode, GetPayload will return immediately with any available payload(can be empty)
The non-full mode is chosen as default mode in engine API. This is necessary in case the block is
generated very slow(e.g. some attack transactions fulfill the pool) and empty block will always
be returned in order to not miss the slot.
This default option is modified in #27736