Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/tracers/js: use t.toBig on ctx.GasPrice for js tracing #27903

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

nettijoe96
Copy link
Contributor

@nettijoe96 nettijoe96 commented Aug 10, 2023

There is a bug in js tracer, ctx.GasPrice.toString(16) returns a number string in base 10.

@nettijoe96 nettijoe96 requested a review from s1na as a code owner August 10, 2023 23:18
@nettijoe96 nettijoe96 changed the title use toBig for GasPrice t.toBig for js tracer ctx.GasPrice Aug 10, 2023
@nettijoe96 nettijoe96 changed the title t.toBig for js tracer ctx.GasPrice use t.toBig on ctx.GasPrice for js tracing Aug 10, 2023
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@holiman holiman added this to the 1.13.0 milestone Aug 15, 2023
@holiman holiman changed the title use t.toBig on ctx.GasPrice for js tracing eth/tracers/js: use t.toBig on ctx.GasPrice for js tracing Aug 15, 2023
@holiman holiman merged commit e0b1198 into ethereum:master Aug 15, 2023
1 of 2 checks passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…27903)

This change fixes a bug in js tracer, where `ctx.GasPrice.toString(16)` returns a number string in base `10`.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants