Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/txpool/blobpool: remove error log when finalized block is nil #27822

Merged
merged 2 commits into from Aug 1, 2023
Merged

core/txpool/blobpool: remove error log when finalized block is nil #27822

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c29db
core/txpool/blobpool: remove error log when finalized block is nil
rjl493456442 Jul 31, 2023
635490f
core/txpool/blobpool: take peter's suggestion
rjl493456442 Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/txpool/blobpool/limbo.go
View file
Open in desktop
Expand Up @@ -117,10 +117,10 @@ func (l *limbo) parseBlob(id uint64, data []byte) error {

// finalize evicts all blobs belonging to a recently finalized block or older.
func (l *limbo) finalize(final *types.Header) {
// Just in case there's no final block yet (network not yet merged, weird
// restart, sethead, etc), fail gracefully.
// Just in case there's no final block yet (syncing, network not yet merged,
// weird restart, sethead, etc), skip the eviction silently.
if final == nil {
log.Error("Nil finalized block cannot evict old blobs")
log.Debug("Nil finalized block cannot evict old blobs")
return
}
for block, ids := range l.groups {
Expand Down