Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/geth: disable automaxprocs log #27814

Merged
merged 3 commits into from Aug 1, 2023
Merged

cmd/geth: disable automaxprocs log #27814

merged 3 commits into from Aug 1, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jul 31, 2023 •
edited

Disable the annoying automaxproc logs

eg:

$ ./build/bin/geth --version

2023/07/31 14:30:26 maxprocs: Leaving GOMAXPROCS=8: CPU quota undefined
geth version 1.12.1-unstable-xyz

Ref uber-go/automaxprocs#18

And we only set CPU limit in geth main process

@jsvisa
cmd/geth: disable automaxprocs log
e307eff 
Signed-off-by: jsvisa <delweng@gmail.com>
rjl493456442
rjl493456442 reviewed Jul 31, 2023
View reviewed changes
cmd/geth/main.go Outdated Show resolved Hide resolved
@jsvisa jsvisa requested a review from rjl493456442 July 31, 2023 13:14
holiman
holiman approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fjl fjl merged commit ff97b4c into ethereum:master Aug 1, 2023
1 of 2 checks passed
@fjl fjl added this to the 1.12.1 milestone Aug 1, 2023
@jsvisa jsvisa deleted the cmd-geth-automaxproc branch August 1, 2023 17:18
MoonShiesty pushed a commit to MoonShiesty/go-ethereum that referenced this pull request Aug 30, 2023
@jsvisa @fjl @MoonShiesty
cmd/geth: disable automaxprocs log (ethereum#27814)
d21c09d 
Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@jsvisa @fjl @devopsbo3
cmd/geth: disable automaxprocs log (ethereum#27814)
45e6620 
Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "cmd/geth: disable automaxprocs log (ethereum#27814)"
01ec8e4 
This reverts commit 45e6620.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "cmd/geth: disable automaxprocs log (ethereum#27814)"
ff1fe1c 
This reverts commit 45e6620.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
@devopsbo3
Revert "cmd/geth: disable automaxprocs log (ethereum#27814)"
9c7b39d 
This reverts commit 45e6620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl approved these changes

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsvisa @fjl @holiman @rjl493456442